WIP: Update vendor github.com/prometheus/common/... #373
Conversation
Follow-up to #372 Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
force-pushed
the
bjk/prom_common
branch
from
c1dbd54 to
c26161a
Compare
* github.com/beorn7/perks/quantile * github.com/golang/protobuf/proto@v1.2.0 * github.com/prometheus/procfs Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
force-pushed
the
bjk/prom_common
branch
from
c26161a to
9b1c702
Compare
|
Oooh, something got removed from common/config... |
Signed-off-by: Ben Kochie <superq@gmail.com>
|
@beorn7 Yea, this one was way out of date. Looks like the use was changed slightly. Pushed a fix. |
Signed-off-by: Ben Kochie <superq@gmail.com>
|
That would enable keepalives for HTTP, which we don't really want for blackbox. |
|
Is that the story where somebody decided keepalive is always good? |
|
No, different thing. Someone was doing some other work which removed the option to disable it, and I hadn't gotten around to fixing it all yet. |
|
Alright. I'd say for now it's fine to not update the prometheus/common vendoring as the metric response size of the blackbox exporter is usually small. |
SuperQ
changed the title
|
Hmm, following prometheus/client_golang#366 , it seems my assumption was wrong and a blackbox exporter might run quite a bit of encoding load. So I guess we should update at least the vendoring of the expfmt package (which could leave out the HTTP config stuff, even if it is ugly to vendor different commits from the same repo) to pull in the text format creation improvement. We should also consider to allow users to disable gzip compression (client_golang allows this via HandlerOpts, but it has to be exposed by a command line flag for the blackbox_exporter). |
|
How about my suggestion above? |
|
Partial vendoring sounds okay to me. |
|
I guess with Go modules (as they are now used in blackbox_exporter), the partial vendoring doesn't work anymore. I guess it makes most sense to close this PR and do a normal Go modules update once |
Follow-up to #372
Signed-off-by: Ben Kochie superq@gmail.com