Add metric successful_config_load #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Shatford <ryan.shatford@tapad.com>
ev1lm0nk3y
force-pushed
the
add-metric
branch
from
470b763
to
72a36fd
Compare
SuperQ
reviewed
Feb 1, 2019
SuperQ
reviewed
Feb 1, 2019
SuperQ
reviewed
Feb 1, 2019
|
I might also introduce a counter for counting all config load errors. |
|
I'm not sure that is useful, however Prometheus has a prometheus_config_last_reload_success_timestamp_seconds |
- Adds Namespace to prometheus metric - metric name more in line with prometheus standards - move metric Set() into a defer block Signed-off-by: Ryan Shatford <ryan.shatford@tapad.com>
|
I agree that the |
|
timestamp_seconds would have the value of the time, not a metric timestamp. |
Signed-off-by: Ryan Shatford <ryan.shatford@tapad.com>
ev1lm0nk3y
force-pushed
the
add-metric
branch
from
0b4d7c5
to
d0958a3
Compare
|
ah, the timestamp of the last successful reload. I've added that metric and cleaned up the code a bit more |
brian-brazil
reviewed
Feb 1, 2019
Signed-off-by: Ryan Shatford <ryan.shatford@tapad.com>
|
yup, i just realized that. should be fixed now. |
Signed-off-by: Ryan Shatford <ryan.shatford@tapad.com>
brian-brazil
reviewed
Feb 4, 2019
brian-brazil
reviewed
Feb 4, 2019
Also move the init() func to under the var block Signed-off-by: Ryan Shatford <ryan.shatford@tapad.com>
ev1lm0nk3y
force-pushed
the
add-metric
branch
from
e3bd402
to
f9923c4
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.