Better handling of HTTP redirects. #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-brazil
force-pushed
the
redirect
branch
3 times, most recently
from
8f0a3f6
to
f0c7711
Compare
If the redirect is to a different host, don't set ServerName. Fixes #237. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
brian-brazil
force-pushed
the
redirect
branch
from
f0c7711
to
6bb72f9
Compare
It can be called concurrently, and after the request has finished. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
|
Hrm, I think I get it. Wouldn't we want to use the new ServerName provided by the redirect? |
|
We don't need to, as the http library will handle it for us. We only need to play around with the first request as we've set the Host header by hand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the redirect is to a different host, don't set ServerName.
Fixes #237.
@discordianfish @SuperQ