Add none/all matches to DNS RRset validation #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you do a make format to make CI happy? |
|
Updated. |
|
The configuration docs need updating too. |
Signed-off-by: Paul Wood <pauwood@ebay.com>
|
Ah, missed that. Updated those too. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current validators for the DNS probers (if_matches/if_not_matches) pass if any record matches/does not match. This patch adds the opposite sense of each, so that a validation will pass if no records match, or all records match. This is much more useful for example with TXT records where you might want to check if a particular record is present or not without failing if any record does not match.