Add option to disable TLS certificate check in DoT #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we have all of the standard tls config stuff here? |
|
@brian-brazil I had that question. But since there already is a TLS probe with those options, I suppose the logical thing is to use that one to test for custom TLS stuff, if you need it, and just disable TLS verification in DoT. In other words, use the DNS and TLS probe in tandem. What do you think? |
|
My point is that we already have a standard way of producing a |
Signed-off-by: André Cruz <acruz@cloudflare.com>
|
I added the TLSConfig block to the DNS probe. |
|
Thanks! |
|
@brian-brazil No, thank you! Are there any plans to release a new version of blackbox_exporter? |
|
Hopefully in the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to TLS probe