Negative maxTimeoutSeconds #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes prometheus#868 Signed-off-by: Kirill Zhdanov <kzhdanov@mirantis.com>
zhdkirill
force-pushed
the
maxTimeoutSeconds
branch
from
00c6314
to
fb6d817
Compare
mem
approved these changes
Apr 11, 2022
electron0zero
approved these changes
Apr 28, 2022
|
@zhdkirill thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a small timeout value in a scraper (Prometheus) without changing the default offset leads to negative timeout values.
Fixes #868
Signed-off-by: Kirill Zhdanov kzhdanov@mirantis.com