Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for HTTP request body as file #987

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Add support for HTTP request body as file #987

merged 3 commits into from
Mar 29, 2023

Conversation

danteu
Copy link
Contributor

@danteu danteu commented Nov 14, 2022

Resolves #391

@danteu danteu changed the title Develop Add support for HTTP request body as file Nov 14, 2022
@danteu
Add HTTP request body test
3025186 
This commit adds a test for specifying a request body for HTTP probes.

Signed-off-by: Daniel Teunis <daniel@teunis.cc>
electron0zero
electron0zero reviewed Nov 15, 2022
View reviewed changes
prober/http_test.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
@danteu
Add support for HTTP request body as file
60af0b8 
Resolves prometheus#391

Signed-off-by: Daniel Teunis <daniel@teunis.cc>
electron0zero
electron0zero approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@electron0zero electron0zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍, thanks for the pr 🎊

@electron0zero electron0zero mentioned this pull request Nov 24, 2022
Open
@danteu
Copy link
Contributor Author

danteu commented Dec 13, 2022

Hi, I was wondering if this could be merged soon or if other changes are required.
ping @roidelapluie (I think you are assigned as the second reviewer)

mem
mem reviewed Dec 15, 2022
View reviewed changes
Copy link
Contributor

@mem mem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor changes. ioutil is deprecated and go.mod already lists version 1.18 as expected.

prober/http_test.go Outdated Show resolved Hide resolved
prober/http_test.go Outdated Show resolved Hide resolved
@mem
Use io instead of io/ioutil
e501757 
Signed-off-by: Marcelo Magallon <marcelo.magallon@gmail.com>
@lefuturiste
Copy link

Hi! I'm also interested in this feature, what is preventing this to go forward to be merged?

@electron0zero electron0zero merged commit 46020dd into prometheus:master Mar 29, 2023
SuperQ added a commit that referenced this pull request May 16, 2023
@SuperQ
Release v0.24.0
7d5011c 
* [CHANGE] Make Proxy Connect Headers consistent with Prometheus #1008
* [FEATURE] Add hostname parameter for TCP probe #981
* [FEATURE] Add support for HTTP request body as file #987

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mem mem mem approved these changes

@electron0zero electron0zero electron0zero approved these changes

@roidelapluie roidelapluie Awaiting requested review from roidelapluie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: ability to specify HTTP probe POST body content as on-disk file
4 participants
@danteu @lefuturiste @mem @electron0zero