-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HTTP request body as file #987
Conversation
This commit adds a test for specifying a request body for HTTP probes. Signed-off-by: Daniel Teunis <daniel@teunis.cc>
Resolves prometheus#391 Signed-off-by: Daniel Teunis <daniel@teunis.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍, thanks for the pr 🎊
Hi, I was wondering if this could be merged soon or if other changes are required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor changes. ioutil is deprecated and go.mod already lists version 1.18 as expected.
Signed-off-by: Marcelo Magallon <marcelo.magallon@gmail.com>
Hi! I'm also interested in this feature, what is preventing this to go forward to be merged? |
Resolves #391