Add probe_dns_query_succeeded metric #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
requested changes
Nov 26, 2022
Currently, one may not be able to differentiate between a query refusal by the target and the target not responding to a query. These two cases can have very different ramifications. This patch adds the probe_dns_query_succeeded gauge which is 1 if and only if the DNS query was executed correctly, i.e., that the target host has sent a response, and 0 otherwise. Resolves prometheus#474 Signed-off-by: Daniel Teunis <daniel@teunis.cc>
danteu
force-pushed
the
dns_target_reachable
branch
from
409239b
to
449e0d7
Compare
danteu
changed the title
danteu
requested review from
SuperQ
and removed request for
mem and
electron0zero
SuperQ
approved these changes
Dec 1, 2022
roidelapluie
added a commit
to roidelapluie/blackbox_exporter
that referenced
this pull request
Dec 2, 2022
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, one may not be able to differentiate between a query refusal
by the target and the target not responding to a query. These two cases
can have very different ramifications.
This patch adds the probe_dns_query_succeeded gauge which is 1 if and
only if the DNS query was executed correctly, i.e., that the target
host has sent a response, and 0 otherwise.
Resolves #474
Signed-off-by: Daniel Teunis daniel@teunis.cc