-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add exemplar support for const histogram and const metric (#986)
* Add support for exemplars on constHistogram Co-authored-by: William Perron <william.perron@shopify.com> Signed-off-by: William Perron <william.perron@shopify.com> * remove GetExemplars function Signed-off-by: William Perron <william.perron@shopify.com> * fixed linting warnings reduce repetition in constHistogram w/ exemplar Signed-off-by: William Perron <william.perron@shopify.com> * Add values to correct bucket Signed-off-by: William Perron <william.perron@shopify.com> * Misc fixes Co-authored-by: Francis Bogsanyi <francis.bogsanyi@shopify.com> Signed-off-by: William Perron <william.perron@shopify.com> * avoid panic when there are fewer buckets than exemplars Co-authored-by: Arun Mahendra <arun.mahendra@shopify.com> Signed-off-by: William Perron <william.perron@shopify.com> * Added MustNewMetricWithExemplars that wraps metrics with exemplar (#3) Changes: * Make sure to not "leak" dto.Metric * Reused upper bounds we already have for histogram * Common code for all types. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Co-authored-by: Arun Mahendra <arun.mahendra@shopify.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
- Loading branch information
1 parent
fe8d1e1
commit 66837e3
Showing
5 changed files
with
251 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters