-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to set CreatedTimestamp on constant histogram metrics #1535
Comments
swar8080
pushed a commit
to swar8080/client_golang
that referenced
this issue
Jun 11, 2024
swar8080
pushed a commit
to swar8080/client_golang
that referenced
this issue
Jun 11, 2024
Closes prometheus#1535 Signed-off-by: Steven Swartz <sswartz@ripple.com>
swar8080
pushed a commit
to swar8080/client_golang
that referenced
this issue
Jun 11, 2024
Closes prometheus#1535 Signed-off-by: Steven Swartz <sswartz@ripple.com>
Hmmmm, interesting. We have I'm supportive of adding the same functionality for ConstHistograms and ConstSummaries. |
swar8080
pushed a commit
to swar8080/client_golang
that referenced
this issue
Jun 29, 2024
Closes prometheus#1535 Signed-off-by: Steven Swartz <sswartz@ripple.com>
swar8080
pushed a commit
to swar8080/client_golang
that referenced
this issue
Jun 29, 2024
Closes prometheus#1535 Signed-off-by: Steven Swartz <sswartz@ripple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#1313 added created timestamp to the internal histogram data model:
https://github.com/ArthurSens/client_golang/blob/e5639d1dcb98e3f1027e110d11ab9eda54e36f34/prometheus/histogram.go#L1202-L1218
I don't see a way for clients to set the value for created timestamp? Specifically we are trying to use
prometheus.NewConstHistogram
I think this is why we're not getting any results when trying to calculate
histogram_quantile
since our_bucket
counts don't start at zero without created timestamp injection. It'd also be nice if the_sum
and_count
metrics had zero injection.Curious to know if hiding created timestamp from clients is intentional here, like if this part of the feature is WIP.
The text was updated successfully, but these errors were encountered: