Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Late encoding errors cannot create HTTP error #542

Closed
beorn7 opened this issue Mar 5, 2019 · 0 comments
Closed

Late encoding errors cannot create HTTP error #542

beorn7 opened this issue Mar 5, 2019 · 0 comments
Assignees
@beorn7
Labels
bug

Comments

@beorn7
Copy link
Member

beorn7 commented Mar 5, 2019

client_golang/prometheus/promhttp/http.go

Line 155 in 2daed26

httpError(rsp, err)

This call will fail with multiple response.WriteHeader calls if something has already been sent down the wire. This needs to be treated in a better way.
@beorn7 beorn7 self-assigned this Mar 5, 2019
@beorn7 beorn7 added the bug label Mar 5, 2019
This was referenced Mar 5, 2019
Open
Closed
@beorn7 beorn7 mentioned this issue May 7, 2019
Merged
beorn7 added a commit that referenced this issue Jun 5, 2019
@beorn7
Add an error counter for internal errors in the HTTP handler
5f808c5 
The doc comments explain the rationale in a quite detailed way.

Fixes #543 and #542

Signed-off-by: beorn7 <beorn@grafana.com>
@beorn7 beorn7 mentioned this issue Jun 5, 2019
Merged
beorn7 added a commit that referenced this issue Jun 5, 2019
@beorn7
Add an error counter for internal errors in the HTTP handler
2df3865 
The doc comments explain the rationale in a quite detailed way.

Fixes #543 and #542

Signed-off-by: beorn7 <beorn@grafana.com>
beorn7 added a commit that referenced this issue Jun 5, 2019
@beorn7
Add an error counter for internal errors in the HTTP handler
3fa9fca 
The doc comments explain the rationale in a quite detailed way.

Fixes #543 and #542

Signed-off-by: beorn7 <beorn@grafana.com>
@beorn7 beorn7 closed this as completed Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beorn7 beorn7

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@beorn7