add _created support: add createdTime() method to counter #1044
Conversation
Signed-off-by: Pengfei Zhang <zhangpengfei@google.com>
|
@beorn7 Please take a look since you are the original owner of that issue. |
|
While I opened this issue, this has to be figured out between the OpenMetrics experts and the current maintainers of prometheus/client_golang. From a very general perspective, I don't think |
Signed-off-by: Pengfei Zhang <zhangpengfei@google.com>
|
Hello, Is this still being discussed? |
|
Can we please do this? |
I will check-in with maintainers about this again. |
There was a problem hiding this comment.
Hi,
Thanks for this. We decided on Prometheus DevSummit to pursue proto version of OpenMetrics format as the main one. So I would implement that first.
For OM v1.0 text format, there are many weird conflicts and incompatibilities (e.g spam of extra metric on all Prometheus versions), so we can't really support it in client_golang and definitely not by default. I would suggest waiting on text improvement for OM e.g in OM 2.0 and rely on proto only.
WDYT?
| valInt uint64 | ||
| valBits uint64 | ||
| valInt uint64 | ||
| createdTime uint64 |
There was a problem hiding this comment.
I don't think this field is ever used, no?
There was a problem hiding this comment.
It's initialized on L166 in initCreated() call.
Presumably, a forthcoming change would use it for serving in a Prometheus counter metric.
There was a problem hiding this comment.
Yup, but we would need this to be either in this PR ideally so we see how end solution would look like 🤗
Definitely it's good direction!
|
BTW, @ArthurSens, our mentee works on adding created timestamp with tests #1044 |
|
Done in #1044, so closing this PR. Thanks anyway! |
|
I believe he meant #1313 |
first step of issue #685
Signed-off-by: Pengfei Zhang zhangpengfei@google.com