Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

histograms: Move to new exposition protobuf format #1092

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

beorn7
Copy link
Member

@beorn7 beorn7 commented Jul 19, 2022

This is only for the sparsehistogram branch.

@marctc feel free to review.

Note that this is an incompatible change. To scrape this new format,
the Prometheus server needs to be updated at the same time. PR
incoming.

Note that this is an incompatible change. To scrape this new format,
the Prometheus server needs to be updated at the same time. PR
incoming.

Signed-off-by: beorn7 <beorn@grafana.com>
beorn7 added a commit to prometheus/prometheus that referenced this pull request Jul 19, 2022
This is an incompatible protobuf change. Instrumented targets must
include prometheus/client_golang#1092 to make
this work.

Signed-off-by: beorn7 <beorn@grafana.com>
@beorn7
Copy link
Member Author

beorn7 commented Jul 19, 2022

prometheus/prometheus#11037 is the corresponding change in prometheus/prometheus.

@beorn7 beorn7 merged commit ec86ef1 into sparsehistogram Jul 20, 2022
@beorn7 beorn7 deleted the beorn7/histogram branch July 20, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants