Remove unnecessary check if label is nil in observeWithExemplar #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimonl
force-pushed
the
Remove_unnecessary_check_labels
branch
from
ecc1668 to
6e53545
Compare
bwplotka
reviewed
Mar 17, 2023
| @@ -31,20 +31,12 @@ const magicString = "zZgWfBxLqvG8kc8IMv3POi2Bb0tZI3vAnBx+gBaFi9FyPzB/CzKUer1yufD | |||
| // observeWithExemplar is a wrapper for [prometheus.ExemplarAdder.ExemplarObserver], | |||
| // which falls back to [prometheus.Observer.Observe] if no labels are provided. | |||
| func observeWithExemplar(obs prometheus.Observer, val float64, labels map[string]string) { | |||
There was a problem hiding this comment.
Nice - I would consider those functions and inline them perhaps. WDYT?
There was a problem hiding this comment.
could you please explain your idea about inline it?
There was a problem hiding this comment.
I mean we should be able to completely remove those functions.
There was a problem hiding this comment.
sure, will rebase and sign. Thanks
dimonl
force-pushed
the
Remove_unnecessary_check_labels
branch
from
6e53545 to
f342b1f
Compare
bwplotka
approved these changes
Mar 19, 2023
|
Do you mind signing you commit (and rebase?). Needed for DCO https://github.com/prometheus/client_golang/pull/1235/checks?check_run_id=12110217881 |
added 2 commits
March 19, 2023 20:27
…umentation Signed-off-by: dlituyev <dlituyev@slb.com>
…umentation Signed-off-by: dlituyev <dlituyev@slb.com>
dimonl
force-pushed
the
Remove_unnecessary_check_labels
branch
from
f342b1f to
b75f672
Compare
signed and rebased |
|
Thanks! |
apricote
referenced
this pull request
in hetznercloud/hcloud-cloud-controller-manager
Apr 13, 2023
….0 (#424) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) | require | minor | `v1.14.0` -> `v1.15.0` | --- ### Release Notes <details> <summary>prometheus/client_golang</summary> ### [`v1.15.0`](https://github.com/prometheus/client_golang/releases/tag/v1.15.0) [Compare Source](https://github.com/prometheus/client_golang/compare/v1.14.0...v1.15.0) #### Changed \[BUGFIX] Fix issue with atomic variables on ppc64le [#​1171](https://github.com/prometheus/client_golang/issues/1171) \[BUGFIX] Support for multiple samples within same metric [#​1181](https://github.com/prometheus/client_golang/issues/1181) \[BUGFIX] Bump golang.org/x/text to v0.3.8 to mitigate CVE-2022-32149 [#​1187](https://github.com/prometheus/client_golang/issues/1187) \[ENHANCEMENT] Add exemplars and middleware examples [#​1173](https://github.com/prometheus/client_golang/issues/1173) \[ENHANCEMENT] Add more context to "duplicate label names" error to enable debugging [#​1177](https://github.com/prometheus/client_golang/issues/1177) \[ENHANCEMENT] Add constrained labels and constrained variant for all MetricVecs [#​1151](https://github.com/prometheus/client_golang/issues/1151) \[ENHANCEMENT] Moved away from deprecated github.com/golang/protobuf package [#​1183](https://github.com/prometheus/client_golang/issues/1183) \[ENHANCEMENT] Add possibility to dynamically get label values for http instrumentation [#​1066](https://github.com/prometheus/client_golang/issues/1066) \[ENHANCEMENT] Add ability to Pusher to add custom headers [#​1218](https://github.com/prometheus/client_golang/issues/1218) \[ENHANCEMENT] api: Extend and improve efficiency of json-iterator usage [#​1225](https://github.com/prometheus/client_golang/issues/1225) \[ENHANCEMENT] Added (official) support for go 1.20 [#​1234](https://github.com/prometheus/client_golang/issues/1234) \[ENHANCEMENT] timer: Added support for exemplars [#​1233](https://github.com/prometheus/client_golang/issues/1233) \[ENHANCEMENT] Filter expected metrics as well in CollectAndCompare [#​1143](https://github.com/prometheus/client_golang/issues/1143) \[ENHANCEMENT]⚠️ Only set start/end if time is not Zero. This breaks compatibility in experimental api package. If you strictly depend on empty time.Time as actual value, the behavior is now changed [#​1238](https://github.com/prometheus/client_golang/issues/1238) <details> <summary>All commits</summary> - Merge release 1.14 to main by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1164](https://github.com/prometheus/client_golang/pull/1164) - Fix typo in doc comment by [@​beorn7](https://github.com/beorn7) in [https://github.com/prometheus/client_golang/pull/1166](https://github.com/prometheus/client_golang/pull/1166) - Fix issue with atomic variables on ppc64le by [@​beorn7](https://github.com/beorn7) in [https://github.com/prometheus/client_golang/pull/1171](https://github.com/prometheus/client_golang/pull/1171) - examples: Add exemplars and middleware examples by [@​jessicalins](https://github.com/jessicalins) in [https://github.com/prometheus/client_golang/pull/1173](https://github.com/prometheus/client_golang/pull/1173) - Add context to "duplicate label names" to enable debugging by [@​SpencerMalone](https://github.com/SpencerMalone) in [https://github.com/prometheus/client_golang/pull/1177](https://github.com/prometheus/client_golang/pull/1177) - Add constrained labels and Constrained variant for all MetricVecs by [@​Okhoshi](https://github.com/Okhoshi) in [https://github.com/prometheus/client_golang/pull/1151](https://github.com/prometheus/client_golang/pull/1151) - Support for multiple samples within same metric by [@​machadovilaca](https://github.com/machadovilaca) in [https://github.com/prometheus/client_golang/pull/1181](https://github.com/prometheus/client_golang/pull/1181) - Replace deprecated github.com/golang/protobuf package by [@​zhsj](https://github.com/zhsj) in [https://github.com/prometheus/client_golang/pull/1183](https://github.com/prometheus/client_golang/pull/1183) - Bump golang.org/x/text to v0.3.8 to mitigate CVE-2022-32149 by [@​b4bay](https://github.com/b4bay) in [https://github.com/prometheus/client_golang/pull/1187](https://github.com/prometheus/client_golang/pull/1187) - typo fix by [@​ibreakthecloud](https://github.com/ibreakthecloud) in [https://github.com/prometheus/client_golang/pull/1178](https://github.com/prometheus/client_golang/pull/1178) - Add possibility to dynamically get label values for http instrumentation by [@​Okhoshi](https://github.com/Okhoshi) in [https://github.com/prometheus/client_golang/pull/1066](https://github.com/prometheus/client_golang/pull/1066) - Bump github.com/cespare/xxhash/v2 from 2.1.2 to 2.2.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1199](https://github.com/prometheus/client_golang/pull/1199) - Bump github.com/prometheus/procfs from 0.8.0 to 0.9.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1198](https://github.com/prometheus/client_golang/pull/1198) - Bump golang.org/x/sys from 0.3.0 to 0.4.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1217](https://github.com/prometheus/client_golang/pull/1217) - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [https://github.com/prometheus/client_golang/pull/1213](https://github.com/prometheus/client_golang/pull/1213) - Bump github.com/prometheus/common from 0.37.0 to 0.39.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1197](https://github.com/prometheus/client_golang/pull/1197) - Add `Header` method to Pusher for custom header by [@​songjiayang](https://github.com/songjiayang) in [https://github.com/prometheus/client_golang/pull/1218](https://github.com/prometheus/client_golang/pull/1218) - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [https://github.com/prometheus/client_golang/pull/1224](https://github.com/prometheus/client_golang/pull/1224) - api: Extend and improve json-iterator usage by [@​beorn7](https://github.com/beorn7) in [https://github.com/prometheus/client_golang/pull/1225](https://github.com/prometheus/client_golang/pull/1225) - Indent example in godoc consistently by [@​lamida](https://github.com/lamida) in [https://github.com/prometheus/client_golang/pull/1226](https://github.com/prometheus/client_golang/pull/1226) - Remove unnecessary check if label is nil in observeWithExemplar by [@​dimonl](https://github.com/dimonl) in [https://github.com/prometheus/client_golang/pull/1235](https://github.com/prometheus/client_golang/pull/1235) - README: Remove not working gocoverage images. by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1236](https://github.com/prometheus/client_golang/pull/1236) - Added support for go 1.20. by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1234](https://github.com/prometheus/client_golang/pull/1234) - timer: Added support for exemplars. by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1233](https://github.com/prometheus/client_golang/pull/1233) - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [https://github.com/prometheus/client_golang/pull/1237](https://github.com/prometheus/client_golang/pull/1237) - Filter expected metrics as well in CollectAndCompare by [@​DariaKunoichi](https://github.com/DariaKunoichi) in [https://github.com/prometheus/client_golang/pull/1143](https://github.com/prometheus/client_golang/pull/1143) - Only set start/end if time is not Zero by [@​jacksontj](https://github.com/jacksontj) in [https://github.com/prometheus/client_golang/pull/1238](https://github.com/prometheus/client_golang/pull/1238) - Bump google.golang.org/protobuf from 1.28.1 to 1.30.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1243](https://github.com/prometheus/client_golang/pull/1243) - Bump golang.org/x/sys from 0.5.0 to 0.6.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1246](https://github.com/prometheus/client_golang/pull/1246) - Bump github.com/golang/protobuf from 1.5.2 to 1.5.3 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1245](https://github.com/prometheus/client_golang/pull/1245) - Bump github.com/prometheus/common from 0.41.0 to 0.42.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1244](https://github.com/prometheus/client_golang/pull/1244) - Cut v1.15.0 by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1249](https://github.com/prometheus/client_golang/pull/1249) </details> #### New Contributors * @​SpencerMalone made their first contributi[https://github.com/prometheus/client_golang/pull/1177](https://github.com/prometheus/client_golang/pull/1177)l/1177 * @​Okhoshi made their first contributi[https://github.com/prometheus/client_golang/pull/1151](https://github.com/prometheus/client_golang/pull/1151)l/1151 * @​machadovilaca made their first contributi[https://github.com/prometheus/client_golang/pull/1181](https://github.com/prometheus/client_golang/pull/1181)l/1181 * @​b4bay made their first contributi[https://github.com/prometheus/client_golang/pull/1187](https://github.com/prometheus/client_golang/pull/1187)l/1187 * @​ibreakthecloud made their first contributi[https://github.com/prometheus/client_golang/pull/1178](https://github.com/prometheus/client_golang/pull/1178)l/1178 * @​songjiayang made their first contributi[https://github.com/prometheus/client_golang/pull/1218](https://github.com/prometheus/client_golang/pull/1218)l/1218 * @​lamida made their first contributi[https://github.com/prometheus/client_golang/pull/1226](https://github.com/prometheus/client_golang/pull/1226)l/1226 * @​dimonl made their first contributi[https://github.com/prometheus/client_golang/pull/1235](https://github.com/prometheus/client_golang/pull/1235)l/1235 * @​DariaKunoichi made their first contributi[https://github.com/prometheus/client_golang/pull/1143](https://github.com/prometheus/client_golang/pull/1143)l/1143 **Full Changelog**: prometheus/client_golang@v1.14.0...v1.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/hetznercloud/hcloud-cloud-controller-manager). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDAuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
renovate bot
referenced
this pull request
in open-feature/flagd
Apr 14, 2023
….0 (#608) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) | require | minor | `v1.14.0` -> `v1.15.0` | --- ### Release Notes <details> <summary>prometheus/client_golang</summary> ### [`v1.15.0`](https://github.com/prometheus/client_golang/releases/tag/v1.15.0) [Compare Source](https://github.com/prometheus/client_golang/compare/v1.14.0...v1.15.0) #### Changed \[BUGFIX] Fix issue with atomic variables on ppc64le [#​1171](https://github.com/prometheus/client_golang/issues/1171) \[BUGFIX] Support for multiple samples within same metric [#​1181](https://github.com/prometheus/client_golang/issues/1181) \[BUGFIX] Bump golang.org/x/text to v0.3.8 to mitigate CVE-2022-32149 [#​1187](https://github.com/prometheus/client_golang/issues/1187) \[ENHANCEMENT] Add exemplars and middleware examples [#​1173](https://github.com/prometheus/client_golang/issues/1173) \[ENHANCEMENT] Add more context to "duplicate label names" error to enable debugging [#​1177](https://github.com/prometheus/client_golang/issues/1177) \[ENHANCEMENT] Add constrained labels and constrained variant for all MetricVecs [#​1151](https://github.com/prometheus/client_golang/issues/1151) \[ENHANCEMENT] Moved away from deprecated github.com/golang/protobuf package [#​1183](https://github.com/prometheus/client_golang/issues/1183) \[ENHANCEMENT] Add possibility to dynamically get label values for http instrumentation [#​1066](https://github.com/prometheus/client_golang/issues/1066) \[ENHANCEMENT] Add ability to Pusher to add custom headers [#​1218](https://github.com/prometheus/client_golang/issues/1218) \[ENHANCEMENT] api: Extend and improve efficiency of json-iterator usage [#​1225](https://github.com/prometheus/client_golang/issues/1225) \[ENHANCEMENT] Added (official) support for go 1.20 [#​1234](https://github.com/prometheus/client_golang/issues/1234) \[ENHANCEMENT] timer: Added support for exemplars [#​1233](https://github.com/prometheus/client_golang/issues/1233) \[ENHANCEMENT] Filter expected metrics as well in CollectAndCompare [#​1143](https://github.com/prometheus/client_golang/issues/1143) \[ENHANCEMENT]⚠️ Only set start/end if time is not Zero. This breaks compatibility in experimental api package. If you strictly depend on empty time.Time as actual value, the behavior is now changed [#​1238](https://github.com/prometheus/client_golang/issues/1238) <details> <summary>All commits</summary> - Merge release 1.14 to main by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1164](https://github.com/prometheus/client_golang/pull/1164) - Fix typo in doc comment by [@​beorn7](https://github.com/beorn7) in [https://github.com/prometheus/client_golang/pull/1166](https://github.com/prometheus/client_golang/pull/1166) - Fix issue with atomic variables on ppc64le by [@​beorn7](https://github.com/beorn7) in [https://github.com/prometheus/client_golang/pull/1171](https://github.com/prometheus/client_golang/pull/1171) - examples: Add exemplars and middleware examples by [@​jessicalins](https://github.com/jessicalins) in [https://github.com/prometheus/client_golang/pull/1173](https://github.com/prometheus/client_golang/pull/1173) - Add context to "duplicate label names" to enable debugging by [@​SpencerMalone](https://github.com/SpencerMalone) in [https://github.com/prometheus/client_golang/pull/1177](https://github.com/prometheus/client_golang/pull/1177) - Add constrained labels and Constrained variant for all MetricVecs by [@​Okhoshi](https://github.com/Okhoshi) in [https://github.com/prometheus/client_golang/pull/1151](https://github.com/prometheus/client_golang/pull/1151) - Support for multiple samples within same metric by [@​machadovilaca](https://github.com/machadovilaca) in [https://github.com/prometheus/client_golang/pull/1181](https://github.com/prometheus/client_golang/pull/1181) - Replace deprecated github.com/golang/protobuf package by [@​zhsj](https://github.com/zhsj) in [https://github.com/prometheus/client_golang/pull/1183](https://github.com/prometheus/client_golang/pull/1183) - Bump golang.org/x/text to v0.3.8 to mitigate CVE-2022-32149 by [@​b4bay](https://github.com/b4bay) in [https://github.com/prometheus/client_golang/pull/1187](https://github.com/prometheus/client_golang/pull/1187) - typo fix by [@​ibreakthecloud](https://github.com/ibreakthecloud) in [https://github.com/prometheus/client_golang/pull/1178](https://github.com/prometheus/client_golang/pull/1178) - Add possibility to dynamically get label values for http instrumentation by [@​Okhoshi](https://github.com/Okhoshi) in [https://github.com/prometheus/client_golang/pull/1066](https://github.com/prometheus/client_golang/pull/1066) - Bump github.com/cespare/xxhash/v2 from 2.1.2 to 2.2.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1199](https://github.com/prometheus/client_golang/pull/1199) - Bump github.com/prometheus/procfs from 0.8.0 to 0.9.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1198](https://github.com/prometheus/client_golang/pull/1198) - Bump golang.org/x/sys from 0.3.0 to 0.4.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1217](https://github.com/prometheus/client_golang/pull/1217) - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [https://github.com/prometheus/client_golang/pull/1213](https://github.com/prometheus/client_golang/pull/1213) - Bump github.com/prometheus/common from 0.37.0 to 0.39.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1197](https://github.com/prometheus/client_golang/pull/1197) - Add `Header` method to Pusher for custom header by [@​songjiayang](https://github.com/songjiayang) in [https://github.com/prometheus/client_golang/pull/1218](https://github.com/prometheus/client_golang/pull/1218) - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [https://github.com/prometheus/client_golang/pull/1224](https://github.com/prometheus/client_golang/pull/1224) - api: Extend and improve json-iterator usage by [@​beorn7](https://github.com/beorn7) in [https://github.com/prometheus/client_golang/pull/1225](https://github.com/prometheus/client_golang/pull/1225) - Indent example in godoc consistently by [@​lamida](https://github.com/lamida) in [https://github.com/prometheus/client_golang/pull/1226](https://github.com/prometheus/client_golang/pull/1226) - Remove unnecessary check if label is nil in observeWithExemplar by [@​dimonl](https://github.com/dimonl) in [https://github.com/prometheus/client_golang/pull/1235](https://github.com/prometheus/client_golang/pull/1235) - README: Remove not working gocoverage images. by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1236](https://github.com/prometheus/client_golang/pull/1236) - Added support for go 1.20. by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1234](https://github.com/prometheus/client_golang/pull/1234) - timer: Added support for exemplars. by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1233](https://github.com/prometheus/client_golang/pull/1233) - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [https://github.com/prometheus/client_golang/pull/1237](https://github.com/prometheus/client_golang/pull/1237) - Filter expected metrics as well in CollectAndCompare by [@​DariaKunoichi](https://github.com/DariaKunoichi) in [https://github.com/prometheus/client_golang/pull/1143](https://github.com/prometheus/client_golang/pull/1143) - Only set start/end if time is not Zero by [@​jacksontj](https://github.com/jacksontj) in [https://github.com/prometheus/client_golang/pull/1238](https://github.com/prometheus/client_golang/pull/1238) - Bump google.golang.org/protobuf from 1.28.1 to 1.30.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1243](https://github.com/prometheus/client_golang/pull/1243) - Bump golang.org/x/sys from 0.5.0 to 0.6.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1246](https://github.com/prometheus/client_golang/pull/1246) - Bump github.com/golang/protobuf from 1.5.2 to 1.5.3 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1245](https://github.com/prometheus/client_golang/pull/1245) - Bump github.com/prometheus/common from 0.41.0 to 0.42.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1244](https://github.com/prometheus/client_golang/pull/1244) - Cut v1.15.0 by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1249](https://github.com/prometheus/client_golang/pull/1249) </details> #### New Contributors * @​SpencerMalone made their first contributi[https://github.com/prometheus/client_golang/pull/1177](https://github.com/prometheus/client_golang/pull/1177)l/1177 * @​Okhoshi made their first contributi[https://github.com/prometheus/client_golang/pull/1151](https://github.com/prometheus/client_golang/pull/1151)l/1151 * @​machadovilaca made their first contributi[https://github.com/prometheus/client_golang/pull/1181](https://github.com/prometheus/client_golang/pull/1181)l/1181 * @​b4bay made their first contributi[https://github.com/prometheus/client_golang/pull/1187](https://github.com/prometheus/client_golang/pull/1187)l/1187 * @​ibreakthecloud made their first contributi[https://github.com/prometheus/client_golang/pull/1178](https://github.com/prometheus/client_golang/pull/1178)l/1178 * @​songjiayang made their first contributi[https://github.com/prometheus/client_golang/pull/1218](https://github.com/prometheus/client_golang/pull/1218)l/1218 * @​lamida made their first contributi[https://github.com/prometheus/client_golang/pull/1226](https://github.com/prometheus/client_golang/pull/1226)l/1226 * @​dimonl made their first contributi[https://github.com/prometheus/client_golang/pull/1235](https://github.com/prometheus/client_golang/pull/1235)l/1235 * @​DariaKunoichi made their first contributi[https://github.com/prometheus/client_golang/pull/1143](https://github.com/prometheus/client_golang/pull/1143)l/1143 **Full Changelog**: prometheus/client_golang@v1.14.0...v1.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDAuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
Unfortunately, not every Fix available here: #1253 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary check if label is nil in observeWithExemplar