-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix top-level examples in push.go. #1298
base: main
Are you sure you want to change the base?
Conversation
As mentioned in the func doc for New(): "However, do not include the “/metrics/jobs/…” part." Signed-off-by: eduarrrd <eduarrrd@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed more specific example URL, but you are right, thanks!
@@ -16,10 +16,10 @@ | |||
// by using its methods, finally calling Add or Push, like this: | |||
// | |||
// // Easy case: | |||
// push.New("http://example.org/metrics", "my_job").Gatherer(myRegistry).Push() | |||
// push.New("http://example.org/", "my_job").Gatherer(myRegistry).Push() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// push.New("http://example.org/", "my_job").Gatherer(myRegistry).Push() | |
// push.New("http://pushgateway.example.org", "my_job").Gatherer(myRegistry).Push() |
// | ||
// // Complex case: | ||
// push.New("http://example.org/metrics", "my_job"). | ||
// push.New("http://example.org/", "my_job"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// push.New("http://example.org/", "my_job"). | |
// push.New("http://pushgateway.example.org", "my_job"). |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
As mentioned in the func doc for New(): "However, do not include the “/metrics/jobs/…” part."