Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

histogram: Enable detection of a native histogram without observations #1314

Merged
merged 2 commits into from
Jul 26, 2023
Merged

histogram: Enable detection of a native histogram without observations #1314

merged 2 commits into from
Jul 26, 2023

Commits on Jul 20, 2023

  1. histograms: Small code comment and code formatting improvements 

    Signed-off-by: beorn7 <beorn@grafana.com>
    @beorn7
    beorn7 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    f9db382 View commit details
    Browse the repository at this point in the history

  2. histogram: Add a no-op span for an otherwise empty histogram 

    Fixes #1127.

If a native histogram has no observations and a zero threshold of
zero, then it is indistinguishable from a classic histogram. To give
scrapers a hint that it is indeed a native histogram, we add a no-op
span.

This needs follow-up PRs in prometheus/prometheus and
prometheus/client_model.

Signed-off-by: beorn7 <beorn@grafana.com>
    @beorn7
    beorn7 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    3d82c94 View commit details
    Browse the repository at this point in the history