Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the name of all variables with min/max name #1606

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

parthlaw
Copy link
Contributor

@parthlaw parthlaw commented Aug 31, 2024

Signed-off-by: Parth Lawania <parthlawania@gmail.com>
@SuperQ SuperQ requested a review from ArthurSens August 31, 2024 10:58
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ArthurSens
Copy link
Member

Thanks! Could you also remove these lines and make sure our linter is happy with your changes?

predeclared:
ignore: "min,max"

@parthlaw
Copy link
Contributor Author

parthlaw commented Sep 1, 2024

Thanks! Could you also remove these lines and make sure our linter is happy with your changes?

predeclared:
ignore: "min,max"

Removed the conditions. Please review the PR again.

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@ArthurSens ArthurSens merged commit 850b6c0 into prometheus:main Sep 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants