Add initial HTTP API v1 package #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // Package prometheus provides bindings to the Prometheus API. |
There was a problem hiding this comment.
Maybe clarify that it's about the HTTP API and even link to http://prometheus.io/docs/querying/api/?
|
👍 otherwise! |
fabxc
force-pushed
the
api
branch
4 times, most recently
from
4af0ac2
to
a061095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of an API package. It supports the querying endpoints of HTTP API v1 – the other ones can be added as needed.
I would consider this beta status as it uses
common/modelwhich we haven't rolled out to client_golang or prometheus in general. It's a good chance to test it out though, as it is independent in this API package.@juliusv