Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTPClient interface to Pusher struct #559

Merged
merged 2 commits into from
May 5, 2019
Merged

Add HTTPClient interface to Pusher struct #559

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9d7791
Add HTTPClient interface to Pusher struct
nghialt Apr 25, 2019
6ea6f07
Replace HTTPClient with HTTPDoer; Update document accordingly
nghialt May 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions prometheus/push/push.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ import (

const contentTypeHeader = "Content-Type"

// HTTPDoer is an interface for the one method of http.Client that is used by Pusher
type HTTPDoer interface {
Do(*http.Request) (*http.Response, error)
}

// Pusher manages a push to the Pushgateway. Use New to create one, configure it
// with its methods, and finally use the Add or Push method to push.
type Pusher struct {
Expand All @@ -61,7 +66,7 @@ type Pusher struct {
gatherers prometheus.Gatherers
registerer prometheus.Registerer

client *http.Client
client HTTPDoer
useBasicAuth bool
username, password string

Expand Down Expand Up @@ -170,7 +175,11 @@ func (p *Pusher) Grouping(name, value string) *Pusher {

// Client sets a custom HTTP client for the Pusher. For convenience, this method
// returns a pointer to the Pusher itself.
func (p *Pusher) Client(c *http.Client) *Pusher {
// Pusher only needs one method of the custom HTTP client: Do(*http.Request).
// Thus, rather than requiring a fully fledged http.Client,
// the provided client only needs to implement the HTTPDoer interface.
// Since *http.Client naturally implements that interface, it can still be used normally.
func (p *Pusher) Client(c HTTPDoer) *Pusher {
p.client = c
return p
}
Expand Down