API Client: Support new metadata endpoint in v1 #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotjosh
force-pushed
the
support-metric-metadata-endpoint
branch
from
77dc78b to
81fed67
Compare
Introduces support for the new metadata endpoint from Prometheus. The new endpoint provides information independent of targets and collapses the unique combinations of HELP, TYPE and UNIT. Fixes prometheus#705 Signed-off-by: gotjosh <josue@grafana.com>
gotjosh
force-pushed
the
support-metric-metadata-endpoint
branch
from
81fed67 to
7f509dc
Compare
gotjosh
commented
Feb 26, 2020
| @@ -366,6 +369,13 @@ type MetricMetadata struct { | |||
| Unit string `json:"unit"` | |||
| } | |||
|
|
|||
| // Metadata models the metadata of a metric. | |||
| type Metadata struct { | |||
There was a problem hiding this comment.
Initially, I tried to re-use the MetricMetadata struct above. However, it felt misleading to return a type that will always have two empty fields (target, metric).
|
On my review queue. Help would be appreciated. @slrtbtfs or @joe-elliott perhaps? |
slrtbtfs
reviewed
Feb 27, 2020
Co-Authored-By: Tobias Guggenmos <tguggenm@redhat.com> Signed-off-by: gotjosh <josue@grafana.com>
Co-Authored-By: Tobias Guggenmos <tguggenm@redhat.com> Signed-off-by: gotjosh <josue@grafana.com>
gotjosh
force-pushed
the
support-metric-metadata-endpoint
branch
from
e321596 to
6c9cb08
Compare
Signed-off-by: gotjosh <josue@grafana.com>
gotjosh
force-pushed
the
support-metric-metadata-endpoint
branch
from
6c9cb08 to
2463b8e
Compare
|
One last 👀 @joe-elliott / @slrtbtfs ? |
beorn7
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces support for the new metadata endpoint from Prometheus. The new endpoint provides information independent of targets and collapses the unique combinations of HELP, TYPE and UNIT.
Fixes #705
Signed-off-by: gotjosh josue@grafana.com