Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement strategy to limit the sparse bucket count #901

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

beorn7
Copy link
Member

@beorn7 beorn7 commented Aug 31, 2021

This is merely a PR against the sparsehistogram branch.

@Dieterbe @codesome Finally a more or less clean version of the bucket limitation strategy.

Signed-off-by: beorn7 <beorn@grafana.com>
Signed-off-by: beorn7 <beorn@grafana.com>
@beorn7 beorn7 requested a review from codesome August 31, 2021 23:28
@beorn7
Copy link
Member Author

beorn7 commented Aug 31, 2021

This is using go1.15 features, which explains why the tests for older go versions fail.

@beorn7
Copy link
Member Author

beorn7 commented Sep 1, 2021

I'll merge this now to cut a Cortex gateway with this.

@beorn7 beorn7 merged commit dfbcc28 into sparsehistogram Sep 1, 2021
@beorn7 beorn7 deleted the beorn7/histogram branch September 1, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant