-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Transactional Gatherer allowed cached solutions #989
Merged
Commits on Jan 25, 2022
-
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> update. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Attempt 2 Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Added blocking registry, with raw collector and transactional handler. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Added fast path to normal (empty) registry to save 8 allocs and 3K5B per Gather. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Simplified API, added tests. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Fix. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Simplified implementation. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Added benchmark. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Optimized. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a1c9be4 - Browse repository at this point
Copy the full SHA a1c9be4View commit details -
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2fcaf51 - Browse repository at this point
Copy the full SHA 2fcaf51View commit details -
Revert "Optimization attempt."
This reverts commit 2fcaf51. Optimization was not worth it: benchstat v1.txt v2.txt name old time/op new time/op delta CachedTGatherer_Update/Update_of_one_element_without_reset-12 2.64µs ± 0% 4.05µs ± 0% ~ (p=1.000 n=1+1) CachedTGatherer_Update/Update_of_all_elements_with_reset-12 701ms ± 0% 358ms ± 0% ~ (p=1.000 n=1+1) CachedTGatherer_Update/Gather-12 535µs ± 0% 703934µs ± 0% ~ (p=1.000 n=1+1) name old alloc/op new alloc/op delta CachedTGatherer_Update/Update_of_one_element_without_reset-12 208B ± 0% 208B ± 0% ~ (all equal) CachedTGatherer_Update/Update_of_all_elements_with_reset-12 40.2MB ± 0% 41.1MB ± 0% ~ (p=1.000 n=1+1) CachedTGatherer_Update/Gather-12 48.6kB ± 0% 84.3kB ± 0% ~ (p=1.000 n=1+1) name old allocs/op new allocs/op delta CachedTGatherer_Update/Update_of_one_element_without_reset-12 3.00 ± 0% 3.00 ± 0% ~ (all equal) CachedTGatherer_Update/Update_of_all_elements_with_reset-12 6.00 ± 0% 4003.00 ± 0% ~ (p=1.000 n=1+1) CachedTGatherer_Update/Gather-12 1.00k ± 0% 2.01k ± 0% ~ (p=1.000 n=1+1)
Configuration menu - View commit details
-
Copy full SHA for 10f1d94 - Browse repository at this point
Copy the full SHA 10f1d94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 273cb92 - Browse repository at this point
Copy the full SHA 273cb92View commit details
Commits on Jan 26, 2022
-
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 870e237 - Browse repository at this point
Copy the full SHA 870e237View commit details -
rename and further optimization.
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 11bdfa3 - Browse repository at this point
Copy the full SHA 11bdfa3View commit details -
benchstat -delta-test=none v6.txt v9.txt name old time/op new time/op delta CachedTGatherer_Update/Update_of_one_element_without_reset-12 13.1ms ± 0% 0.0ms ± 0% -99.81% CachedTGatherer_Update/Update_of_all_elements_with_reset-12 309ms ± 0% 282ms ± 0% -8.77% CachedTGatherer_Update/Gather-12 422ms ± 0% 0ms ± 0% -99.95% name old alloc/op new alloc/op delta CachedTGatherer_Update/Update_of_one_element_without_reset-12 208B ± 0% 208B ± 0% 0.00% CachedTGatherer_Update/Update_of_all_elements_with_reset-12 2.47kB ± 0% 1.67kB ± 0% -32.56% CachedTGatherer_Update/Gather-12 52.8kB ± 0% 24.6kB ± 0% -53.34% name old allocs/op new allocs/op delta CachedTGatherer_Update/Update_of_one_element_without_reset-12 3.00 ± 0% 3.00 ± 0% 0.00% CachedTGatherer_Update/Update_of_all_elements_with_reset-12 0.00 0.00 0.00% CachedTGatherer_Update/Gather-12 1.00k ± 0% 0.00k ± 0% -99.60% Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 961f8ca - Browse repository at this point
Copy the full SHA 961f8caView commit details
Commits on Feb 17, 2022
-
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8bbbe7a - Browse repository at this point
Copy the full SHA 8bbbe7aView commit details
Commits on Feb 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8caf328 - Browse repository at this point
Copy the full SHA 8caf328View commit details -
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 81d86fb - Browse repository at this point
Copy the full SHA 81d86fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for cba52a7 - Browse repository at this point
Copy the full SHA cba52a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29c7671 - Browse repository at this point
Copy the full SHA 29c7671View commit details -
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c4563c4 - Browse repository at this point
Copy the full SHA c4563c4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.