Fix UnknownDataPointSnapshot constructor (#977)

Signed-off-by: Mickael Maison <mickael.maison@gmail.com>
prometheus · Jul 30, 2024 · d567081 · d567081
1 parent 594a9de
commit d567081
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/...us-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/UnknownSnapshot.java b/...us-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/UnknownSnapshot.java
@@ -40,7 +40,7 @@ public static final class UnknownDataPointSnapshot extends DataPointSnapshot {
          * @param exemplar may be null.
          */
         public UnknownDataPointSnapshot(double value, Labels labels, Exemplar exemplar) {
-            this(value, Labels.EMPTY, exemplar, 0);
+            this(value, labels, exemplar, 0);
         }
 
         /**

diff --git a/...etrics-model/src/test/java/io/prometheus/metrics/model/snapshots/UnknownSnapshotTest.java b/...etrics-model/src/test/java/io/prometheus/metrics/model/snapshots/UnknownSnapshotTest.java
@@ -68,4 +68,20 @@ public void testNameMissing() {
     public void testValueMissing() {
         UnknownSnapshot.UnknownDataPointSnapshot.builder().build();
     }
+
+    @Test
+    public void testUnknownDataPointSnapshot() {
+        Labels labels = Labels.of("k1", "v1");
+        Exemplar exemplar = Exemplar.builder().value(2.0).build();
+
+        UnknownSnapshot.UnknownDataPointSnapshot data = new UnknownSnapshot.UnknownDataPointSnapshot(1.0, labels, exemplar);
+        Assert.assertEquals(1.0, data.getValue(), 0.1);
+        Assert.assertEquals(labels, data.getLabels());
+        Assert.assertEquals(exemplar, data.getExemplar());
+
+        data = new UnknownSnapshot.UnknownDataPointSnapshot(1.0, labels, exemplar, 0L);
+        Assert.assertEquals(1.0, data.getValue(), 0.1);
+        Assert.assertEquals(labels, data.getLabels());
+        Assert.assertEquals(exemplar, data.getExemplar());
+    }
 }