Optimize label building

Signed-off-by: Ian Ker-Seymer <i.kerseymer@gmail.com>
prometheus · Jul 14, 2020 · f50ee67 · f50ee67
1 parent aa41f5f
commit f50ee67
Showing 1 changed file with 3 additions and 13 deletions.
diff --git a/lib/prometheus/middleware/collector.rb b/lib/prometheus/middleware/collector.rb
@@ -68,20 +68,10 @@ def trace(env)
 
       def record(env, code, duration)
         path = env[Rack::SCRIPT_NAME] + env[Rack::PATH_INFO]
+        shared_labels = { method: env['REQUEST_METHOD'].downcase, path: strip_ids_from_path(path) }
 
-        counter_labels = {
-          code:   code,
-          method: env['REQUEST_METHOD'].downcase,
-          path:   strip_ids_from_path(path),
-        }
-
-        duration_labels = {
-          method: env['REQUEST_METHOD'].downcase,
-          path:   strip_ids_from_path(path),
-        }
-
-        @requests.increment(labels: counter_labels)
-        @durations.observe(duration, labels: duration_labels)
+        @requests.increment(labels: { code: code, **shared_labels })
+        @durations.observe(duration, labels: shared_labels)
       rescue
         # TODO: log unexpected exception during request recording
         nil