Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JRuby 9.3 to the build matrix #264

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Add JRuby 9.3 to the build matrix #264

merged 1 commit into from
Aug 21, 2022

Conversation

Sinjo
Copy link
Member

@Sinjo Sinjo commented Aug 21, 2022

I don't really follow JRuby any more, so this release passed me by, but
I figure it's worth adding to our build matrix.

I don't really follow JRuby any more, so this release passed me by, but
I figure it's worth adding to our build matrix.

Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>
@Sinjo Sinjo requested a review from dmagliola August 21, 2022 11:47
Copy link
Collaborator

@dmagliola dmagliola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On that note, Ruby 2.6 is EOL.
Should we remove it since we only officially support current versions?
Or should we leave it since it doesn't really cost us anything?

@Sinjo
Copy link
Member Author

Sinjo commented Aug 21, 2022

I was tempted to remove it until I read this line in our comptibility docs:

Whenever a version of Ruby falls out of support we will mirror that change in the Prometheus Ruby client by updating the build matrix and releasing a new major version.

I'm normally not too averse to bumping major version, but seeing as the carrying cost of having 2.6 in our CI matrix is basically 0, I'm happy to leave it there for now. It would feel slightly strange to bump to 5.0 without having released any features/improvements since 4.0.

@Sinjo Sinjo merged commit ea01d97 into main Aug 21, 2022
@Sinjo Sinjo deleted the sinjo-new-jruby branch August 21, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants