Fix pushgateway paths. #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since pushgateway released v0.7.0 deprecated `/metrics/jobs/` interface was removed and only singularized `/metrics/job/` supports now. Signed-off-by: Pavel Nikitin <daddybutcher@gmail.com>
butcher
force-pushed
the
fix-pushgateway-paths
branch
from
6f6f7ca to
c2c4d59
Compare
|
Looks like |
This was referenced Jan 21, 2019
Merged
|
Apologies. This slipped through the radar of the maintainers. The problem has been fixed in #102 by now. Closing this. Thanks for your contribution anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @grobie, please review this fix, cause currently
ruby_clientis broken.Since pushgateway released v0.7.0 deprecated
/metrics/jobs/interfacewas removed and only singularized
/metrics/job/support now.See pushgateway release notes and PR that removes deprecated API