src/encoding/text.rs: Expose Encoder methods #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By exposing the various `Encoder` builder methods, downstream users can implement their custom metrics using `EncodeMetric`. Signed-off-by: Max Inden <mail@max-inden.de>
Signed-off-by: Max Inden <mail@max-inden.de>
Signed-off-by: Max Inden <mail@max-inden.de>
mxinden
force-pushed
the
custom-collector
branch
from
14b2883
to
0545eaf
Compare
|
Sorry, I forgot about this. I'll give it a look soon :) |
|
This seems perfect, I was able to quickly get my test working with this (which was almost 1:1 with the example you added) :) |
phyber
approved these changes
Feb 2, 2022
ackintosh
pushed a commit
to ackintosh/client_rust
that referenced
this pull request
Aug 27, 2022
By exposing the various `Encoder` builder methods, downstream users can implement their custom metrics using `EncodeMetric`. Showcase how to implement custom metric with example. Signed-off-by: Max Inden <mail@max-inden.de> Signed-off-by: ackintosh <sora.akatsuki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By exposing the various
Encoderbuilder methods, downstream users canimplement their custom metrics using
EncodeMetric.See #36 for additional context.
//CC @phyber