Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add with_prefix to Registry #70

Merged
merged 4 commits into from
Jul 14, 2022
Merged

Add with_prefix to Registry #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d20a333
Add with_prefix
Victor-N-Suadicani Jul 8, 2022
dd3a716
Update src/registry.rs
Victor-N-Suadicani Jul 11, 2022
23ad729
Added to changelog
Victor-N-Suadicani Jul 11, 2022
c2b53ee
Update CHANGELOG.md
mxinden Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [0.17.0] - unreleased

### Changed

- Updates to Rust 2021 Edition. See [PR 65].

### Removed
### Added
- Added a `with_prefix` method to `Registry` to allow initializing a registry with a prefix. See [PR 70].

### Removed
- Remove `Add` trait implementation for a private type which lead to compile time conflicts with existing `Add` implementations e.g. on `String`. See [PR 69].

[PR 65]: https://github.com/prometheus/client_rust/pull/65
[PR 69]: https://github.com/prometheus/client_rust/pull/69
[PR 70]: https://github.com/prometheus/client_rust/pull/70

## [0.16.0]

Expand Down
8 changes: 8 additions & 0 deletions src/registry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,14 @@ impl<M> Default for Registry<M> {
}

impl<M> Registry<M> {
/// Creates a new default [`Registry`] with the given prefix.
pub fn with_prefix(prefix: impl Into<String>) -> Self {
mxinden marked this conversation as resolved.
Show resolved Hide resolved
Self {
prefix: Some(Prefix(prefix.into())),
..Default::default()
}
}

/// Register a metric with the [`Registry`].
///
/// Note: In the Open Metrics text exposition format some metric types have
Expand Down