Add support for tuning a receive buffer of the UDP socket #36
Conversation
|
No comments? |
|
@hasso Sorry and thanks for the ping. This fells through the cracks. I'm wondering, the default connection setup in your new vendoring (when the user doesn't specify their own
Maybe add those to your custom connection setup too? |
| @@ -248,6 +250,25 @@ func startCollectdServer(ctx context.Context, w api.Writer) { | |||
| log.Fatalf("Unknown security level %q. Must be one of \"None\", \"Sign\" and \"Encrypt\".", *collectdSecurity) | |||
| } | |||
|
|
|||
| laddr, err := net.ResolveUDPAddr("udp", *collectdAddress) | |||
| if err != nil { | |||
| log.Fatal(err) | |||
There was a problem hiding this comment.
These log.Fatals should have some wrapper error message before the raw returned error, like the log.Fatal above in line 250. In this case here, something like:
log.Fatalf("Failed to resolve binary protocol listening UDP address %q: %v", *collectdAddress, err)
| srv.Conn, err = net.ListenUDP("udp", laddr) | ||
| } | ||
| if err != nil { | ||
| log.Fatal(err) |
|
Never closing the connection is probably ok in this case, as it would only get closed when the program exits anyways. |
|
I made log messages more informative now. The code already handles the case when address is empty – in collectd_exporter context this means that binary protocol server isn't started at all. Which is completely valid use case of course. I'm not sure about multicast – I don't use it and I'm not even sure that it should be there. Yes, I know that collectd supports that, but I consider such use a problematic can of worms in practice. Adding support for specifying interface is easy, but it adds another command line option which wouldn't be used in reality, probably. If you say it's OK, I can add the code of course. |
|
Good point about the empty address! About multicast: no real idea either, but yeah, after reading the code once again I tend to agree. Thanks! 👍 |
In case of larger collectd traffic there is a need to increase a receive buffer of the UDP socket to avoid drops. Increasing defaults in OS is not often what you really want to do, as it changes default for all sockets in the system.
With go-collectd you can create your own socket, apply all needed options and pass it to the Server (collectd/go-collectd#22).
Probably there should be defer to close the socket as well somewhere, but I'm not really sure how it should be used with goroutines.