Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.5.0 #95

Merged
merged 1 commit into from
May 11, 2020
Merged

Release 0.5.0 #95

merged 1 commit into from
May 11, 2020

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented May 8, 2020

Signed-off-by: Ben Kochie superq@gmail.com

* [CHANGE] Switch logging to go-kit (#85)

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ SuperQ requested a review from juliusv May 8, 2020 16:43
@SuperQ
Copy link
Member Author

SuperQ commented May 8, 2020

This also upgrades the vendoring, including the latest Go collectd library. Also a Go 1.7 -> 1.14 rebuild.

@roidelapluie
Copy link
Member

Can we deprecate at the same time?

@juliusv
Copy link
Member

juliusv commented May 11, 2020

Ah great that @SuperQ is already working on a release, thanks!

Yeah @roidelapluie, I would propose making this the last release of the collectd exporter and then marking it as deprecated at the top of the README.md (see https://groups.google.com/forum/#!topic/prometheus-users/scP-0JcEgtc for context), with a text like:

NOTE: THIS EXPORTER HAS BEEN DEPRECATED IN FAVOR OF UPSTREAM PROMETHEUS SUPPORT IN COLLECTD: https://collectd.org/wiki/index.php/Plugin:Write_Prometheus.

Please switch to the upstream Prometheus module for collectd and work with the authors there to add any missing functionality. We will not be accepting changes to this exporter anymore and will be removing the exporter repository in due time.

@juliusv
Copy link
Member

juliusv commented May 11, 2020

And 👍 on this PR :)

@SuperQ
Copy link
Member Author

SuperQ commented May 11, 2020

I'd like to have a discussion about marking this deprecated. Maybe @octo is interested in weighing in on this.

I'd suggest opening a separate issue to discuss arching this project. For now, I'd like to cut a release as normal. We can add a deprecation notice afterwards.

@SuperQ SuperQ merged commit 8e37c19 into master May 11, 2020
@SuperQ SuperQ deleted the superq/0.5.0 branch May 11, 2020 13:19
@juliusv
Copy link
Member

juliusv commented May 11, 2020

See my last reply on the thread I linked (I had screwed up the CC to list, so you'll only see @octo's reply quoted by me there). Basically:

I'm not aware of anything that the collectd_exporter does that the
"write_prometheus" plugin doesn't support – and I'm happy to get the
plugin to feature parity if anything comes up.

So I think we can safely deprecate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants