Support multiple headers, drop canonicalize names when not needed

Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>

config/headers.go

@@ -59,6 +59,9 @@ type Headers struct {
 // SetDirectory records the directory to make headers file relative to the
 // configuration file.
 func (h *Headers) SetDirectory(dir string) {
+	if h == nil {
+		return
+	}
 	h.dir = dir
 }
 

config/http_config_test.go

@@ -1680,3 +1680,33 @@ func TestHeaders(t *testing.T) {
 		t.Fatalf("can't fetch URL: %v", err)
 	}
 }
+
+func TestMultipleHeaders(t *testing.T) {
+	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		for k, v := range map[string][]string{
+			"One":   {"value1a", "value1b", "value1c"},
+			"Two":   {"value2a", "value2b", "value2c"},
+			"Three": {"value3a", "value3b", "value3c"},
+		} {
+			if !reflect.DeepEqual(r.Header.Values(k), v) {
+				t.Errorf("expected %v, got %v", v, r.Header.Values(k))
+			}
+		}
+		w.WriteHeader(http.StatusNoContent)
+	}))
+	t.Cleanup(ts.Close)
+
+	cfg, _, err := LoadHTTPConfigFile("testdata/http.conf.headers-multiple.good.yaml")
+	if err != nil {
+		t.Fatalf("Error loading HTTP client config: %v", err)
+	}
+	client, err := NewClientFromConfig(*cfg, "test")
+	if err != nil {
+		t.Fatalf("Error creating HTTP Client: %v", err)
+	}
+
+	_, err = client.Get(ts.URL)
+	if err != nil {
+		t.Fatalf("can't fetch URL: %v", err)
+	}
+}

config/testdata/headers-file-a

@@ -0,0 +1,3 @@
+value3a
+
+

config/testdata/headers-file-b

@@ -0,0 +1 @@
+value3b 

config/testdata/headers-file-c

@@ -0,0 +1 @@
+value3c

config/testdata/http.conf.headers-multiple.good.yaml

@@ -0,0 +1,7 @@
+http_headers:
+  headers:
+    one: [value1a, value1b, value1c]
+  secret_headers:
+    two: [value2a, value2b, value2c]
+  files:
+    three: [testdata/headers-file-a, testdata/headers-file-b, testdata/headers-file-c ]