Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unmarshal URL's with urls.redacted #245

Open
roidelapluie opened this issue Jul 21, 2020 · 4 comments
Open

Unmarshal URL's with urls.redacted #245

roidelapluie opened this issue Jul 21, 2020 · 4 comments

Comments

@roidelapluie
Copy link
Member

I propose that since go 1.15 supports url.Redacted, we make used of it while unmarshaling urls.

This could be done my adding a URL wrapper in this repo.

golang/go#34855
@brian-brazil
Copy link
Contributor

We provide a way that occludes secrets for basic auth, do we really need this? Also the way Go occludes is different to the way we do it in terms of placeholder, which would be confusing.

@roidelapluie
Copy link
Member Author

We do not provide a way to do Proxy Authentication.

@brian-brazil
Copy link
Contributor

Then that is something we should discuss, I think there's an issue for it lying about somewhere.

@simonpasquier
Copy link
Member

It was #128

alanprot pushed a commit to alanprot/common that referenced this issue Mar 15, 2023
@bboreham
Merge pull request prometheus#245 from aknuds1/chore/hide-tls-params
67d27ed 
server: Removing advanced TLS config parameters - BREAKING CHANGE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@roidelapluie @simonpasquier @brian-brazil