Support HTTP2 #233
Merged
Support HTTP2 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it's just ForceAttemptHTTP2 we need to set? |
|
https://github.com/golang/net/blob/master/http2/transport.go#L136 it is doing way more than that, and errors if it is already configured |
|
Are you sure they're doing something different? That'd seem like a bug to me. |
|
I will try this out, indeed this more recent than what I have read |
|
Breaks go < 1.13 |
config/http_config.go
Outdated
| @@ -153,6 +154,12 @@ func NewRoundTripperFromConfig(cfg HTTPClientConfig, name string, disableKeepAli | |||
| conntrack.DialWithName(name), | |||
| ), | |||
| } | |||
| // TODO: use ForceAttemptHTTP2 when we move to go 1.13+ | |||
There was a problem hiding this comment.
Go
And don't forget your full stop.
According to my readings, as we provide a custom transport, we have to configure it to use HTTP2. golang/go#20645 I have tested the behaviour of this and it is correct. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to my readings, as we provide a custom transport, we have to
configure it to use HTTP2.
golang/go#20645
I have tested the behaviour of this and it is correct.
Signed-off-by: Julien Pivotto roidelapluie@inuits.eu