Enable HTTP/2 again #261
Closed
Enable HTTP/2 again #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that golang/go#39337 and golang/go#40201 are fixed: - We now have a function to configure HTTP/2 transport, therefore we have a "ping" every 5 minutes on the line if not traffic is doing on - Dead HTTP/2 connections will be removed from the pool Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
|
golang/go#39750 and golang/go#32388 aren't closed yet, is this really ready to go? Do we need to wait for a Go release? We should also have the original reporter try all of this out to be sure. |
|
I was thinking golang/go#39337 is the same as golang/go#39750 , and golang/go#32388 is solved by setting the timeouts? |
|
I'm not sure looking at those, @JensErat can you help us figure out if this is all sufficiently fixed on Go's end? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that golang/go#39337 and
golang/go#40201 are fixed:
therefore we have a "ping" every 5 minutes on the line
if not traffic is doing on
Signed-off-by: Julien Pivotto roidelapluie@inuits.eu