Remove private field in http config #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The private field in http config is causing issue while implementing in Prometheus. It was there to be nice with importers who would import the code and not call Validate(). I still want to be nice so I have added a workaround for those users. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
roidelapluie
force-pushed
the
remote-private-field
branch
from
ce973bc
to
45105da
Compare
This was referenced Feb 17, 2021
beorn7
approved these changes
Feb 18, 2021
This was referenced Mar 11, 2021
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The private field in http config is causing issue while implementing in
Prometheus. It was there to be nice with importers who would import the
code and not call Validate(). I still want to be nice so I have added a
workaround for those users.
Signed-off-by: Julien Pivotto roidelapluie@inuits.eu