Replace go-kit/kit with go-kit/log #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com> Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims
changed the title
|
Thank you!! 💯 I wanted to bump client_golang and common in etcd, but couldn't due to the go-kit needing etcd :D |
|
Thanks! |
mrueg
added a commit
to mrueg/pushgateway
that referenced
this pull request
Aug 4, 2021
See also: prometheus/common#304 Signed-off-by: Manuel Rüger <manuel@rueg.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/go-kit/kitis only being used for the log packages and brings in a lot of dependencies as compared github.com/go-kit/log. This would help determine how useful switching would be.For reference see kubernetes/kubernetes#102144 and this discussion.
Fix for #255