-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build/test #353
Update build/test #353
Conversation
CC @mrueg |
the build tags in: |
As requested in prometheus/common#353 (comment) Signed-off-by: Manuel Rüger <manuel@rueg.eu>
As requested in prometheus/common#353 (comment) Signed-off-by: Manuel Rüger <manuel@rueg.eu>
abf03eb
to
b4f3fd6
Compare
Bleh, deprecated use linter errors. |
@SuperQ I assume those could be treated similar to Let me know if there's anything I can do to get this into a state in which it can be merged. |
b4f3fd6
to
19f4cca
Compare
* Use `make -C dir` instead of `cd dir && make` * Cleanup uncessary working_directory in config. * Update Go modules to latest. * Drop support for old Go versions. * Cleanup old Go version build tweaks. * Fixup some deprecated method use. Signed-off-by: SuperQ <superq@gmail.com>
19f4cca
to
3c43b4d
Compare
Ok, let me know if the changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @beorn7 any opinion on the changes in expfmt?
I think they are fine. |
As requested in prometheus/common#353 (comment) Signed-off-by: Manuel Rüger <manuel@rueg.eu>
make -C dir
instead ofcd dir && make
Signed-off-by: SuperQ superq@gmail.com