Add histogram vectors to model #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenador
force-pushed
the
sparsehistograms
branch
3 times, most recently
from
2c58700
to
63beb45
Compare
zenador
force-pushed
the
sparsehistograms
branch
from
e40cdbb
to
72dc02e
Compare
|
Cool. I hope I can help with a review soon… |
beorn7
requested changes
Dec 15, 2022
codesome
reviewed
Dec 16, 2022
zenador
force-pushed
the
sparsehistograms
branch
4 times, most recently
from
14ed1f8
to
57e36a0
Compare
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
… enum Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
…sion - experimental) Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
zenador
force-pushed
the
sparsehistograms
branch
from
57e36a0
to
84e64de
Compare
|
Quick note: Bumping the minimum required Go version is a bit of an issue as prometheus/client_golang has to be conservative in this regard (and it uses prometheus/common). Currently, client_golang requires go1.17. Generally, they try to support the last three Go minor releases at the very least. In short, I think, it would be better at this time to avoid generics and only require go1.17. |
codesome
reviewed
Jan 3, 2023
…g go version - experimental)" This reverts commit 84e64de. Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
zenador
force-pushed
the
sparsehistograms
branch
from
41cdb02
to
6a3d5c0
Compare
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
This reverts commit f451854. Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
zenador
force-pushed
the
sparsehistograms
branch
from
6a3d5c0
to
0267435
Compare
beorn7
approved these changes
Jan 7, 2023
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2 tasks
|
I assume if @roidelapluie had issues with this, he would have chimed in by now. So, merging now… Thank you very much, @zenador . |
This was referenced Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses prometheus/client_golang#1179
Tested the JSON decoding successfully by scraping a simple server running native histograms with Prometheus, then using the HTTP API in
client_golang(which does not need to be updated, only this library needs updating) to query it.