-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Go older than 1.18 #612
Conversation
We don't support Go older than 1.21 in the Go modules file, so we can drop the special handling for older Go in the version package. Signed-off-by: SuperQ <superq@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if the comment sounds lazy, I'm still stuck between airports and not very familiar with runtime libraries.
if v.Key == "-tags" { | ||
tags = v.Value | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm reading the BuildSettings docs and I can't find the -tags keys.
Is this something that was removed in more recent versions of go? Or just missing in the docs?
// A BuildSetting is a key-value pair describing one setting that influenced a build.
//
// Defined keys include:
//
// - -buildmode: the buildmode flag used (typically "exe")
// - -compiler: the compiler toolchain flag used (typically "gc")
// - CGO_ENABLED: the effective CGO_ENABLED environment variable
// - CGO_CFLAGS: the effective CGO_CFLAGS environment variable
// - CGO_CPPFLAGS: the effective CGO_CPPFLAGS environment variable
// - CGO_CXXFLAGS: the effective CGO_CXXFLAGS environment variable
// - CGO_LDFLAGS: the effective CGO_LDFLAGS environment variable
// - GOARCH: the architecture target
// - GOAMD64/GOARM/GO386/etc: the architecture feature level for GOARCH
// - GOOS: the operating system target
// - vcs: the version control system for the source tree where the build ran
// - vcs.revision: the revision identifier for the current commit or checkout
// - vcs.time: the modification time associated with vcs.revision, in RFC3339 format
// - vcs.modified: true or false indicating whether the source tree had local modifications
type BuildSetting struct {
// Key and Value describe the build setting.
// Key must not contain an equals sign, space, tab, or newline.
// Value must not contain newlines ('\n').
Key, Value string
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list is not claimed to be exclusive; it says it “includes” those things.
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.51.1` -> `v0.52.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.52.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.52.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.51.1/v0.52.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.51.1/v0.52.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.52.2`](https://github.com/prometheus/common/releases/tag/v0.52.2) [Compare Source](https://github.com/prometheus/common/compare/v0.51.1...v0.52.2) #### What's Changed - Drop support for Go older than 1.18 by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#612 - fix(protobuf): Correctly decode multi-messages streams by [@​srebhan](https://github.com/srebhan) in [prometheus/common#616 - Bump github.com/aws/aws-sdk-go from 1.50.31 to 1.51.11 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#615 #### New Contributors - [@​srebhan](https://github.com/srebhan) made their first contribution in [prometheus/common#616 **Full Changelog**: prometheus/common@v0.51.1...v0.52.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.48.0` -> `v0.52.3` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.52.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.52.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.48.0/v0.52.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.48.0/v0.52.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.52.3`](https://github.com/prometheus/common/compare/v0.52.2...v0.52.3) [Compare Source](https://github.com/prometheus/common/compare/v0.52.2...v0.52.3) ### [`v0.52.2`](https://github.com/prometheus/common/releases/tag/v0.52.2) [Compare Source](https://github.com/prometheus/common/compare/v0.51.1...v0.52.2) #### What's Changed - Drop support for Go older than 1.18 by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#612 - fix(protobuf): Correctly decode multi-messages streams by [@​srebhan](https://github.com/srebhan) in [prometheus/common#616 - Bump github.com/aws/aws-sdk-go from 1.50.31 to 1.51.11 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#615 #### New Contributors - [@​srebhan](https://github.com/srebhan) made their first contribution in [prometheus/common#616 **Full Changelog**: prometheus/common@v0.51.1...v0.52.2 ### [`v0.51.1`](https://github.com/prometheus/common/releases/tag/v0.51.1) [Compare Source](https://github.com/prometheus/common/compare/v0.51.0...v0.51.1) #### What's Changed - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#606 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#609 - Retract v0.50.0 by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#610 **Full Changelog**: prometheus/common@v0.51.0...v0.51.1 ### [`v0.51.0`](https://github.com/prometheus/common/releases/tag/v0.51.0) [Compare Source](https://github.com/prometheus/common/compare/v0.50.0...v0.51.0) #### What's Changed - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#604 - expfmt: Add a way to generate different OpenMetrics Formats by [@​ywwg](https://github.com/ywwg) in [prometheus/common#596 - Fix string slice definition for FormatFlagOptions. by [@​gizmoguy](https://github.com/gizmoguy) in [prometheus/common#607 - Correct logic in sample naming for counters, add new test by [@​vesari](https://github.com/vesari) in [prometheus/common#608 #### New Contributors - [@​gizmoguy](https://github.com/gizmoguy) made their first contribution in [prometheus/common#607 **Full Changelog**: prometheus/common@v0.50.0...v0.51.0 ### [`v0.50.0`](https://github.com/prometheus/common/releases/tag/v0.50.0) [Compare Source](https://github.com/prometheus/common/compare/v0.49.0...v0.50.0) #### What's Changed - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#594 - Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#593 - Bump github.com/aws/aws-sdk-go from 1.50.27 to 1.50.29 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#592 - Bump github.com/aws/aws-sdk-go from 1.50.29 to 1.50.31 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#595 - Remove unused 'Host' member from HTTPClientConfig by [@​bboreham](https://github.com/bboreham) in [prometheus/common#597 - Add OpenMetrics unit support by [@​vesari](https://github.com/vesari) in [prometheus/common#544 - Remove deprecated version function by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#591 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#599 - Bump golang.org/x/oauth2 from 0.17.0 to 0.18.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#600 - Bump google.golang.org/protobuf from 1.32.0 to 1.33.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#601 **Full Changelog**: prometheus/common@v0.49.0...v0.50.0 ### [`v0.49.0`](https://github.com/prometheus/common/releases/tag/v0.49.0) [Compare Source](https://github.com/prometheus/common/compare/v0.48.0...v0.49.0) #### What's Changed - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#574 - Bump github.com/aws/aws-sdk-go from 1.49.13 to 1.50.8 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#571 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#581 - Update Go by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#588 - Deprecate version.NewCollector by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#579 - Bump github.com/aws/aws-sdk-go from 1.50.8 to 1.50.27 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#587 - Avoid off-spec openmetrics exposition when exemplars have empty labels by [@​orls](https://github.com/orls) in [prometheus/common#569 - Bump golang.org/x/oauth2 from 0.16.0 to 0.17.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#585 - Write created lines when negotiating OpenMetrics by [@​ArthurSens](https://github.com/ArthurSens) in [prometheus/common#504 - Upgrade client_model to v.0.6.0 by [@​vesari](https://github.com/vesari) in [prometheus/common#589 - http_config: Add host by [@​jkroepke](https://github.com/jkroepke) in [prometheus/common#549 - LabelSet: Fix alphabetical sorting for prometheus LabelSet by [@​wasim-nihal](https://github.com/wasim-nihal) in [prometheus/common#575 - labelset: optimise String() function by [@​bboreham](https://github.com/bboreham) in [prometheus/common#590 #### New Contributors - [@​orls](https://github.com/orls) made their first contribution in [prometheus/common#569 - [@​vesari](https://github.com/vesari) made their first contribution in [prometheus/common#589 **Full Changelog**: prometheus/common@v0.48.0...v0.49.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
…#32250) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.51.1` -> `v0.52.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.52.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.52.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.51.1/v0.52.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.51.1/v0.52.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.52.2`](https://github.com/prometheus/common/releases/tag/v0.52.2) [Compare Source](https://github.com/prometheus/common/compare/v0.51.1...v0.52.2) #### What's Changed - Drop support for Go older than 1.18 by [@&open-telemetry#8203;SuperQ](https://github.com/SuperQ) in [prometheus/common#612 - fix(protobuf): Correctly decode multi-messages streams by [@&open-telemetry#8203;srebhan](https://github.com/srebhan) in [prometheus/common#616 - Bump github.com/aws/aws-sdk-go from 1.50.31 to 1.51.11 in /sigv4 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#615 #### New Contributors - [@&open-telemetry#8203;srebhan](https://github.com/srebhan) made their first contribution in [prometheus/common#616 **Full Changelog**: prometheus/common@v0.51.1...v0.52.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
We don't support Go older than 1.21 in the Go modules file, so we can drop the special handling for older Go in the version package.