Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that Prometheus 2.0 no longer supports the protobuf exposition format #927

Closed
cite-reader opened this issue Nov 23, 2017 · 7 comments
Assignees

Comments

@cite-reader
Copy link

The documentation page on exposition formats states:

A server will prefer receiving the protocol-buffer format, and will fall back to the text-based format if the client does not support the former.

As of Prometheus 2.0.0, this is not true. It doesn't seem to support the protobuf format at all.

That section of prose should be updated to reflect that fact, and the Supported in secton of the comparison table should reflect the upper version bound, at a minimum. More generally this page could probably stand to be rewritten to reflect conclusions from, for instance, this discussion.

@juliusv
Copy link
Member

juliusv commented Jun 1, 2018

While the table on https://prometheus.io/docs/instrumenting/exposition_formats/ lists the protobuf version as supported only in ">=0.4.0, <2.0.0" now, that could indeed still be made clearer throughout the doc, especially now that most people should be on Prometheus 2.0.

@lucperkins
Copy link
Contributor

@cite-reader @juliusv I'm happy to handle this. Feel free to assign me.

@RichiH
Copy link
Member

RichiH commented Jun 20, 2018

@lucperkins I sent you an invitiation to join this repo; you can then take issues yourself. As always, all commits must go through a PR.

@juliusv
Copy link
Member

juliusv commented Jun 20, 2018

Yup, GitHub currently does not let me assign you, you'll have to join the repo :)

@brian-brazil
Copy link
Contributor

There's no reference in the migration doc.

@rektide
Copy link
Contributor

rektide commented Oct 18, 2019

The original ticket linked a url, https://github.com/RichiH/OpenMetrics/blob/master/protobuf_vs_text.md , on protobuf vs text. That link is now 404.

Is there any documentation anywhere on the deprecation of protobufs? Any kind of migration announcement? I'm trying to find something to mention about this change, but I can't find any discussion on the web I can use to cite this event in Prometheus's life (other than this ticket, which doesn't discuss why this was done, or what happened, only mentions the ask for such a note).

Edit:

aylei pushed a commit to aylei/docs that referenced this issue Oct 28, 2019
…metheus#927)

* benchmark: add Sysbench Test Result of TiDB 3.0 Beta on NVMe SSD

* Add content of TiDB config file

* benchmark: update wording

* benchmark: improve wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants