include error message with exception #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase against master, and add the DCO? |
rustyrazorblade
force-pushed
the
improve_error_output
branch
from
7dd7e8c
to
92bc987
Compare
Signed-off-by: Jon Haddad <jon@jonhaddad.com>
rustyrazorblade
force-pushed
the
improve_error_output
branch
from
92bc987
to
16d70ec
Compare
|
You got it. |
|
Looks like Travis has broken jdk8 installs, so I'll just merge this. |
nakyo7
pushed a commit
to nakyo7/jmx_exporter
that referenced
this pull request
Jul 18, 2019
…rometheus#399) Signed-off-by: Jon Haddad <jon@jonhaddad.com> Signed-off-by: Kiho Na <kiho.na@nhnpayco.com>
qinghui-xu
pushed a commit
to qinghui-xu/jmx_exporter
that referenced
this pull request
Sep 18, 2020
…rometheus#399) Signed-off-by: Jon Haddad <jon@jonhaddad.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the agent starts up, you get the same output no matter what is wrong:
This patch adds the exception to the output:
cc @brian-brazil,