Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to add IPv6 as a parameter for http server #450

Merged
merged 3 commits into from
Nov 26, 2019

Conversation

ndimitry
Copy link
Contributor

@ndimitry ndimitry commented Nov 26, 2019

Small change that allows to add IPv6 hosts

dnazaruk added 3 commits November 21, 2019 15:48
Signed-off-by: dnazaruk <dmitrii.nazaruk@t-systems.com>
Signed-off-by: dnazaruk <dmitrii.nazaruk@t-systems.com>
@brian-brazil
Copy link
Contributor

Do we need any changes on the java agent side?

@ndimitry
Copy link
Contributor Author

ndimitry commented Nov 26, 2019

No, no changes are required in the agent.
JavaAgent class contains method parseConfig which parses data in an even more sophisticated and enhanced way (but there 3 parameters are possible [host:]<port>:<config> and regular expressions are used for parsing)

@brian-brazil brian-brazil merged commit 38f135e into prometheus:master Nov 26, 2019
@brian-brazil
Copy link
Contributor

Thanks!

@ndimitry
Copy link
Contributor Author

Welcome (: not that big change.
And I made a typo in my previous comment, there should be: "3 parameters are possible [host:]<port>:<config>" (didn't know I should escape < and >, now I do)

qinghui-xu pushed a commit to qinghui-xu/jmx_exporter that referenced this pull request Sep 18, 2020
* make it possible to pass IPv6 parameters for the host

Signed-off-by: dnazaruk <dmitrii.nazaruk@t-systems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants