SEVERE: JMX scrape failed: java.lang.ClassCastException: javax.management.openmbean.TabularDataSupport cannot be cast to javax.management.Attribute

[nbonavia]

Added a sanitary check to the JMX Scraper so that it will skip Attributes processing that are not javax.management.Attribute types. This is an issue present in Apache Ignite, when there are some Attributes that are of type javax.management.openmbean.TabularDataSupport

Signed-off-by: Neville Bonavia neville.bonavia@gig.com

The error log in such a situation is: -
Oct 08, 2020 1:28:28 PM io.prometheus.jmx.JmxCollector collect
SEVERE: JMX scrape failed: java.lang.ClassCastException: javax.management.openmbean.TabularDataSupport cannot be cast to javax.management.Attribute
at io.prometheus.jmx.JmxScraper.scrapeBean(JmxScraper.java:163)
at io.prometheus.jmx.JmxScraper.doScrape(JmxScraper.java:117)
at io.prometheus.jmx.JmxCollector.collect(JmxCollector.java:542)
at io.prometheus.client.CollectorRegistry$MetricFamilySamplesEnumeration.findNextElement(CollectorRegistry.java:190)
at io.prometheus.client.CollectorRegistry$MetricFamilySamplesEnumeration.nextElement(CollectorRegistry.java:223)
at io.prometheus.client.CollectorRegistry$MetricFamilySamplesEnumeration.nextElement(CollectorRegistry.java:144)
at io.prometheus.client.exporter.common.TextFormat.write004(TextFormat.java:22)
at io.prometheus.client.exporter.HTTPServer$HTTPMetricHandler.handle(HTTPServer.java:68)
at com.sun.net.httpserver.Filter$Chain.doFilter(Filter.java:79)
at sun.net.httpserver.AuthFilter.doFilter(AuthFilter.java:83)
at com.sun.net.httpserver.Filter$Chain.doFilter(Filter.java:82)
at sun.net.httpserver.ServerImpl$Exchange$LinkHandler.handle(ServerImpl.java:675)
at com.sun.net.httpserver.Filter$Chain.doFilter(Filter.java:79)
at sun.net.httpserver.ServerImpl$Exchange.run(ServerImpl.java:647)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)

[brian-brazil]

Thanks!

Has someone filed a bug against Ignite?

[bjorndemicoli]

i was actually tired of crying on this issue, neville just saved my life.

[sdarlington]

Has anyone successfully used this patch? In my use, I'm getting an exception on line 160 (in attributes.asList()) and needed to put an extra try/catch block around the for loop (sdarlington@8cfc075). Am I missing something?

[azsane]

Dig into source code in openjdk8
AttributeList.java

if non Attribute type obj is added to AttributeList,the tainted became true
When asList is invoked,type check will performed at adding
Since typeSafe flag is on , exception will be thrown if non Attribute type obj is encounted

So at least in openjdk implementation, returned normally asList() doesn't need any Class Type check
but in abnormal case,you can only catch exception thrown by asList

The fix in line 160 should change to
for (Object attributeObj : attributes) {
AttributeList extends ArrayList and can be iterated directrly

[hholierhoek]

Agreed, this doesn't work. I get the same exception down in asList().

[piotrrybicki]

for ignite 2.9.1, blacklisting views in jmx_exporter config allows other metrics to be exposed :

blacklistObjectNames: ["org.apache:clsLdr=*,group=views,*"]

[xudesheng]

Dig into source code in openjdk8
AttributeList.java

if non Attribute type obj is added to AttributeList,the tainted became true
When asList is invoked,type check will performed at adding
Since typeSafe flag is on , exception will be thrown if non Attribute type obj is encounted

So at least in openjdk implementation, returned normally asList() doesn't need any Class Type check
but in abnormal case,you can only catch exception thrown by asList

The fix in line 160 should change to
for (Object attributeObj : attributes) {
AttributeList extends ArrayList and can be iterated directrly

agreed and tested.

Can anyone create a new pull request to fix this issue?