Use artifactId to generate debian package name #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This restore previous behavior, otherwise the package is not installable on debian systems: |
Skunnyk
force-pushed
the
debian_package_name
branch
from
b61573b
to
945dd1b
Compare
|
It would bee great to get this merged. We prefer installing debian packages over hand crafting installations, but this bug is preventing us from using newer versions of jmx exporter. |
- Since 77a5b8f, "name" is "Prometheus JMX Exporter - Http Server", which break debian package generation - use artifactId to get a correct name Signed-off-by: Romain Bouvier <skunnyk@alteroot.org>
Skunnyk
force-pushed
the
debian_package_name
branch
from
945dd1b
to
51957ff
Compare
|
Hi :) Is it possible for this PR to be merged ? This is really a small change affecting debian package build (which is advertised in the README), and it would be super awesome to have it fixed for the next release 🙏 |
|
Thanks a lot for the reminder and for the PR, it's merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JMX Exporter - Http Server", which break debian package generation