-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally disable all default exports for JavaAgent #698
base: main
Are you sure you want to change the base?
Optionally disable all default exports for JavaAgent #698
Conversation
Signed-off-by: udesaiitrs <udesai@itrsgroup.com>
Fix #696 |
@udesaiitrs I agree this could be useful in specific scenarios... but I feel that the configuration should be added to the configuration YAML. |
Sorry for the delay. As @dhoard mentioned, there is a branch for a new YAML config file format that we are working on. It was originally started for extended SSL configuration options, but it also introduces advanced filtering which will achieve what you need. Here's an example: https://github.com/prometheus/jmx_exporter/blob/new-config/integration_tests/ssl_tests/src/test/resources/test-config-new.yaml It's still work in progress. Do you think this would solve the issue? |
Sorry for the delay, yes something like this is exactly what we're looking for. Will this also apply to the JVM metrics collected by the jmx exporter? We collect JVM metrics via our own custom collector, and do not want the default JVM metrics collected by the exporter. Any eta on when it will be released? |
Seems to be stuck. And we're still waiting |
Yes this would solve the issue I believe, is there an ETA on merging/releasing this change? |
Signed-off-by: udesaiitrs udesai@itrsgroup.com
@tomwilkie @fstab We've had increased requests to support this to reduce duplicated JVM metrics being collected from the jmx_exporter. This is a rough PR, please let me know if this is something we can include in the next release.