-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP BASIC authentication #801
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoard
force-pushed
the
basic-authentication
branch
8 times, most recently
from
May 8, 2023 00:44
76e397d
to
a2965d2
Compare
dhoard
force-pushed
the
basic-authentication
branch
17 times, most recently
from
May 11, 2023 02:15
008a758
to
125b2d8
Compare
dhoard
force-pushed
the
basic-authentication
branch
from
May 16, 2023 16:20
415c2fb
to
b1ae7b5
Compare
Changes
|
fstab
requested changes
May 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Doug! I found a few things to comment, mainly focusing on the production code (not tests) for now.
collector/src/main/java/io/prometheus/jmx/util/map/MapAccessor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: dhoard <doug.hoard@gmail.com>
Signed-off-by: dhoard <doug.hoard@gmail.com>
…m application output Signed-off-by: dhoard <doug.hoard@gmail.com>
…SHA based authentication Signed-off-by: dhoard <doug.hoard@gmail.com>
Signed-off-by: dhoard <doug.hoard@gmail.com>
dhoard
force-pushed
the
basic-authentication
branch
from
May 20, 2023 01:25
2fc1270
to
bfbae1b
Compare
Signed-off-by: dhoard <doug.hoard@gmail.com>
Signed-off-by: dhoard <doug.hoard@gmail.com>
Signed-off-by: dhoard <doug.hoard@gmail.com>
fstab
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Doug!
dhoard
added a commit
to dhoard/jmx_exporter
that referenced
this pull request
Jun 20, 2023
* HTTP Basic authentication Signed-off-by: dhoard <doug.hoard@gmail.com>
Merged
dhoard
added a commit
that referenced
this pull request
Jun 30, 2023
* HTTP Basic authentication Signed-off-by: dhoard <doug.hoard@gmail.com> Signed-off-by: Doug Hoard <doug.hoard@gmail.com>
dhoard
added a commit
that referenced
this pull request
Jun 30, 2023
* HTTP Basic authentication Signed-off-by: dhoard <doug.hoard@gmail.com> Signed-off-by: Doug Hoard <doug.hoard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Implemented HTTP BASIC authentication.
The implementation consistents of 3 types of configuration providers:
SHA-1
,SHA-256
, etc.)PBKDF2WithHmacSHA1
,PBKDF2WithHmacSHA256
, etc.)Refactored project to use Java 8 as a baseline (no Java 6 support)
Refactored integration tests to use smoke test containers when running in IntelliJ
@fstab please review