Move session params to DSN #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid lost session params if the `db` object reconnects in the background, move session params to the DSN string configuration.
SuperQ
force-pushed
the
superq/connect_params
branch
from
121694d to
f7b639c
Compare
|
@SuperQ You are the best, yes, thank you makes more sense and looks IMO more clean. |
* Update flag name to be in `exporter` namespace. * Update README.
|
@arvenil Ok, I had to move the |
arvenil
reviewed
Jan 22, 2018
README.md
Outdated
| @@ -76,7 +76,8 @@ Name | Description | |||
| -------------------------------------------|-------------------------------------------------------------------------------------------------- | |||
| config.my-cnf | Path to .my.cnf file to read MySQL credentials from. (default: `~/.my.cnf`) | |||
| log.level | Logging verbosity (default: info) | |||
| log_slow_filter | Add a log_slow_filter to avoid exessive MySQL slow logging. NOTE: Not supported by Oracle MySQL. | |||
| exporter.lock_wait_timeout | Set a lock_wait_timeout on the connection to avoid long metadata locking. (default: 2 seconds) | |||
| exporter.log_slow_filter | Add a log_slow_filter to avoid exessive MySQL slow logging. NOTE: Not supported by Oracle MySQL. | |||
There was a problem hiding this comment.
Just a bonus question, what's the purpose of this flag in the exporter? To overwrite global log_slow_filter or to avoid query logging of exporter own queries?
This was a bit unclear to me from above description but after I found #60 the sentence "to avoid slow query logging of scrapes" makes it more clear.
There was a problem hiding this comment.
It's a session flag to avoid the exporter logging its own queries. Yes, I think your description of the flag is better.
|
@arvenil Let me know if there's any other issues. |
arvenil
approved these changes
Jan 22, 2018
Closed
arvenil
referenced
this pull request
in percona/mysqld_exporter
Jan 31, 2018
SuperQ
pushed a commit
that referenced
this pull request
Jan 31, 2018
ezraroi
pushed a commit
to ezraroi/mysqld_exporter
that referenced
this pull request
Apr 17, 2018
# This is the 1st commit message: Move session params to DSN (prometheus#259) * Move session params to DSN In order to avoid lost session params if the `db` object reconnects in the background, move session params to the DSN string configuration. * Move log_slow_filter flag to exporter * Update flag name to be in `exporter` namespace. * Update README. * Tweak exporter.log_slow_filter flag documentation. # This is the commit message prometheus#2: Fix lock_wait_timeout after prometheus#259 (prometheus#263) # This is the commit message prometheus#3: Broken landing page, doesn't include metric path. (prometheus#264) * Broken landing page, doesn't include metric path. * Fix landing page. # This is the commit message prometheus#4: first commit Signed-off-by: Roi Ezra <ezraroi@gmail.com> # This is the commit message prometheus#5: fixed code review Signed-off-by: Roi Ezra <ezraroi@gmail.com> # This is the commit message prometheus#6: fixed code review Signed-off-by: Roi Ezra <ezraroi@gmail.com>
ezraroi
added a commit
to ezraroi/mysqld_exporter
that referenced
this pull request
Apr 17, 2018
Move session params to DSN (prometheus#259) * Move session params to DSN In order to avoid lost session params if the `db` object reconnects in the background, move session params to the DSN string configuration. * Move log_slow_filter flag to exporter * Update flag name to be in `exporter` namespace. * Update README. * Tweak exporter.log_slow_filter flag documentation. Fix lock_wait_timeout after prometheus#259 (prometheus#263) Broken landing page, doesn't include metric path. (prometheus#264) * Broken landing page, doesn't include metric path. * Fix landing page. first commit Signed-off-by: Roi Ezra <ezraroi@gmail.com> fixed code review Signed-off-by: Roi Ezra <ezraroi@gmail.com> fixed code review Signed-off-by: Roi Ezra <ezraroi@gmail.com> first commit Signed-off-by: Roi Ezra <ezraroi@gmail.com> fixed code review fixed code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid lost session params if the
dbobject reconnects inthe background, move session params to the DSN string configuration.