Use GLOBAL to prevent mysql deadlock #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very interesting, seems reasonable to me. |
|
Please sign your commit with |
|
Hrm, it looks like your commit history is a little strange now. |
|
Yeah, trying out a new tool called sublime merge. Looks like it did a pull/merge before I pushed the signed commit. No further changes though. Need me to figure out how to remove that? |
Signed-off-by: Cody Taylor <cody@codytaylor.org>
|
Yes, it would be nice. It seems like the commit history is making the DCO bot confused. |
codytaylor
force-pushed
the
use-GLOBAL-to-prevent-complete-mysql-lockup
branch
from
04d7ccb to
6bf0ec9
Compare
|
Looks good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SuperQ
In mysql 5.7.22 we encountered an issue where the entire process would completely lock up. We were able to solve it by modifying this one file and also removing the '--collect.binlog_size' param from the mysqld exporter.
Here is the bug report: https://bugs.mysql.com/bug.php?id=92108