Add perf_schema.eventsstatementssum collector #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay in reviewing this, I've been catching up on things after traveling. I'll try and get to this soon. |
|
This needs a rebase. |
Signed-off-by: Alexey Medvedchikov <alexey.medvedchikov@gmail.com>
|
Sorry, I didn't notice this had been re-based. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds collector with aggregated perf_schema.eventstatements metrics (when it makes sense).
The reason why I did this is that we have a lot of MySQL servers with different SQL queries and multiplication X by Y gives us an enormous number of series. We would like to monitor this values still, but it requires either complex setup of Prometheus servers with the federation, either switching off this collector on most of the servers.
Having this collector enables allows us to have an overview of all performance events, and thanks to
collect[]parameter feature easily enable extra verbose collector on problematic ones.Basically, this code is copied and modified
collector/perf_schema_events_statements.goone.