Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collector to get table stats grouped by schema #354

Merged
merged 2 commits into from
Feb 4, 2019

Conversation

maeserichar
Copy link
Contributor

Adding a new collector to get the table stats info (if available) grouped by schema.

@SuperQ

@maeserichar maeserichar force-pushed the table_stats_by_schema branch 2 times, most recently from 7c39afb to 1f1345b Compare December 4, 2018 16:29
@dannyk81
Copy link

ping @SuperQ 😄

@SuperQ
Copy link
Member

SuperQ commented Jan 21, 2019

Please add a [FEATURE] line to the CHANGELOG.md and

@maeserichar maeserichar force-pushed the table_stats_by_schema branch from d904b78 to 538212f Compare January 22, 2019 14:44
@maeserichar
Copy link
Contributor Author

Looks like the failing check does not have nothing to do with my changes. @SuperQ Can you relaunch it? Thanks!

@SuperQ
Copy link
Member

SuperQ commented Jan 22, 2019

Hrm, it's still failing. Can you make sure your branch is rebased against the latest master? We made some fixes to the build system.

Ricardo Rodríguez added 2 commits January 23, 2019 09:01
Signed-off-by: Ricardo Rodríguez <rrodriguez@tuenti.com>
Signed-off-by: Ricardo Rodríguez <rrodriguez@tuenti.com>
@maeserichar maeserichar force-pushed the table_stats_by_schema branch from 538212f to 1ec3daf Compare January 23, 2019 08:03
@maeserichar
Copy link
Contributor Author

Yes, of course. Thanks!

@maeserichar
Copy link
Contributor Author

ping @SuperQ

@SuperQ SuperQ merged commit 72b576b into prometheus:master Feb 4, 2019
@maeserichar maeserichar deleted the table_stats_by_schema branch February 4, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants